Status of merge into Plone 3.0
Status of the kss merge
Merged into the trunk.
1. Functionality issues
- 1.1 We needed to comment out the javascript include
- from Archetypes/skins/archetypes/widgets/addable_support.pt. This affects the addability support in the reference and inandout widgets. The current code defines a per-widget-instance javascript (whereas in AT only per-widget-type javascript is allowed). This does not work well of course with reloading. Following our strategy with similar cases, the javascript (that is generated via dtml) must be transformed to clean javascript (no dtml) and hooked to kss (like we did with the content menus). The current solution must be held as legacy code for fallback if kss is not working. More information is available.
2. Test issues
It means it "works" but the test does not work.
Failing tests:
- kss.core: 0
- kss.demo: 0
- plone.app.kss 3
- archetypes.kss 0
Details:
- 2.2 plone.app.kss:
-
the test view is declared but it's not picked up. (Needs to be fixed.)
A bit more details. In https://svn.plone.org/svn/plone/plone.app.kss/trunk/tests/test_part_reloading.py there are these lines:
# register the sample view load_config('configure-part_reloading.zcml', package=plone.app.kss.tests) self.view = self.portal.restrictedTraverse('change_title')
The traversing fails, although the zcml looks good. Now, if I move the load_config call _into_ loadCoreConfig, called earlier, it works. loadCoreConfig is in the base testcase in http://codespeak.net/svn/kukit/kss.core/trunk/tests/base.py .
I just don't understand, why the view is not declared, and why is it declared if called from loadCoreConfig?